fix(shutdown): emit VectorStopped after topology drains

changelog.d/24532_vector_stopped_log_ordering.fix.md

@@ -0,0 +1,3 @@
+Fixed log message ordering on shutdown where `Vector has stopped.` was logged before
+components had finished draining, causing confusing output interleaved with
+`Waiting on running components` messages.

src/app.rs

@@ -493,16 +493,18 @@ impl FinishedApplication {
     }
 
     async fn stop(topology_controller: TopologyController, mut signal_rx: SignalRx) -> ExitStatus {
-        emit!(VectorStopped);
         tokio::select! {
-            _ = topology_controller.stop() => ExitStatus::from_raw({
-                #[cfg(windows)]
-                {
-                    exitcode::OK as u32
-                }
-                #[cfg(unix)]
-                exitcode::OK
-            }), // Graceful shutdown finished
+            _ = topology_controller.stop() => {
+                emit!(VectorStopped);
+                ExitStatus::from_raw({
+                    #[cfg(windows)]
+                    {
+                        exitcode::OK as u32
+                    }
+                    #[cfg(unix)]
+                    exitcode::OK
+                })
+            }, // Graceful shutdown finished
             _ = signal_rx.recv() => Self::quit(),
         }
     }