feat(deployment): add sd_notify integration with watchdog support#25072
Open
newtonne wants to merge 4 commits intovectordotdev:masterfrom
Open
feat(deployment): add sd_notify integration with watchdog support#25072newtonne wants to merge 4 commits intovectordotdev:masterfrom
newtonne wants to merge 4 commits intovectordotdev:masterfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds systemd
sd_notifyintegration to Vector, enabling enhanced service lifecycle management when running under systemd withType=notify.Vector now sends:
READY=1when fully started and ready to process eventsSTOPPING=1at the beginning of graceful shutdownWATCHDOG=1keepalive pings at half the configuredWatchdogSecintervalThe bundled
vector.serviceandhardened-vector.serviceunit files are updated to useType=notify, with an optional commented outWatchdogSecdirective.See: https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html
Vector configuration
No config changes required.
How did you test this PR?
Type=notify:READY=1is sent after startup is completedSTOPPING=1is sent on systemctl stopWATCHDOG=1pings are sent at the correct interval withWatchdogSecenabledType=simpleBefore
Note that systemd shows vector as started as soon as the process has forked.
After
But now systemd shows vector as started only after vector has finished starting up.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.