Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(external): fix network_* metric type #22118

Merged
merged 1 commit into from
Jan 3, 2025
Merged

docs(external): fix network_* metric type #22118

merged 1 commit into from
Jan 3, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jan 3, 2025 •
edited
Loading

Summary

Set the metric type to counter.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested review from a team as code owners January 3, 2025 16:41
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 3, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 3, 2025
@pront pront enabled auto-merge January 3, 2025 16:41
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/fix-network-metric-doc
Commit report: 73a6524
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.47s Total Time

@pront pront added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit 35845a1 Jan 3, 2025
76 of 78 checks passed
@pront pront deleted the pront/fix-network-metric-doc branch January 3, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drichards-87 drichards-87 drichards-87 approved these changes

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect metric type for network collector in docs
3 participants
@pront @jszwedko @drichards-87