fix(config): Correct filter transform generation via vector generate to use a comparison
#22079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
domain: transforms
jszwedko
changed the title
filter transform generation via vector generate to use a comparison
jszwedko
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Thanks for this @abcdam ! Do you mind adding a changelog entry per https://github.com/vectordotdev/vector/blob/master/changelog.d/README.md
…to use a comparison
auto-merge was automatically disabled
January 2, 2025 20:09
Head branch was pushed to by a user without write access
abcdam
force-pushed
the
fix/generator-typo
branch
from
fc07a86 to
f021fb5
Compare
|
Should be fine now @jszwedko. Also it seems like gh didn't like the rebase + squash.. |
jszwedko
approved these changes
Jan 2, 2025
jszwedko
reviewed
Jan 2, 2025
changelog.d/22079_correct_filter_condition_via_vector_generate.fix.md
Outdated
Show resolved
Hide resolved
|
Thanks @abcdam ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typo in filter component produced by
vector generateSummary
Change Type
Is this a breaking change?
How did you test this PR?
Untested. I stumbled upon it while playing around with
vector generatein the cli.Can be reproduced with e.g.
# vector generate /filter. If this PR doesn't follow the guidelines, feel free to delete it and push the fix.Does this PR include user facing changes?
Checklist
Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References