-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix( gcp_chronicle sink): add content encoding header when compression is enabled #22009
Conversation
This looks good to me. I don't have an E2E environment to confirm how adding this header affects downstream GCP. Did you have a chance to see if you get 200 responses with this fix? |
Co-authored-by: Pavlos Rontidis <[email protected]>
I have got an environment I can test in I'm struggling to get a complete build to test. I'll keep trying |
Hi @ChocPanda, what I meant was, can you repeat what you described in the test plan?
Also, a CI check is failing. Otherwise this is good to go! |
Hey @pront, sorry for the delay, I got taken out by the flu in the new year. I can confirm that I have been able to build and test this change and it resolves the issue. I tested the change by reproducing the issue by configuring gzip compression on a chronicle sink with the public vector 0.43.0 image and then resolved the issue by changing to an image built using this branch using the same vector config with gzip compression enabled |
Summary
Set the Content Encoding header when configuring compression on the gcp chronicle sink
Change Type
Is this a breaking change?
How did you test this PR?
Test using the config in the issue #22007
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References