🎶 Media Bridge, with audio sync 🎶 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtshkmr
changed the title
rtshkmr
commented
Feb 28, 2024
rtshkmr
commented
Feb 29, 2024
rtshkmr
commented
Feb 29, 2024
assets/js/hooks/media_player.js
Outdated
| const { | ||
| detail, | ||
| } = e | ||
| const [key, val, extraKey] = detail?.payload |
There was a problem hiding this comment.
todo: add guard instead of doing a tuple de-structure here because if detail?.payload is null or undefined, the iterator used for destructuring will throw a type exception
throwback to the previous issue where we had the audio timestamp change when we used the audio player to seek to something. this is the cause for aud and video going out of sync immediate next steps: 1. cleanup and ensure the data flow is happening correctly i.e. event emitters and listeners need to have correct reponsibilities 2. Key UI changes -- let the video player be a miniplayer anchored to the currently emphasised event...
There seems to be 2 options: 1. using sticky w.r.t vh 2. using this inset seems like 1 won't work because different liveview components get rendered in different parent containers, and in 1, v is w.r.t to it's specific parent.
The joy from this is amazing...
quick rundown of how multiple theming can be done: 1. app.css defines css vars e.g. --color-brand-accent 2. tailwind config uses css vars e.g. colorBrandAccent 3. css vars can be programmatically changed ref example tldr by phind: https://www.phind.com/search?cache=zjy65pla8499wua9on23rjof
This is not entirely complete, some quirks exist, but it is intended to represent how a topic-specific events bridge can be used.
TLDR;
1. there are 2 initiators:
- initiated when progress bar is clicked
- initiated when verse is clicked ==> media_bridge.ex server issues seekTime
2. we can categorise events based on emitters / producers or consumers.
3. consumers generally consume events and generally only have internal
actions they carry out
4. sometimes, consumers may have external actions they carry out as
well. For example, if MediaBridge hook gets a server-initiated request
to seekTime, then it shall carry out internal actions (i.e. seekToS, as
well as pub the seekTimePayload to others via the seekTimeBridge)
This has some bugs, but the overall pattern should be correct. Also pending cleanups
ks0m1c
changed the base branch from
chore/player-improvements
to
feature/hanuman
📺 Video <> Audio Sync 📺
Rework playback architecture to use dispatcher
|
Loose ends
|
…unch Basic UI polishing
Add Keyboard Bookmarklet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status: ready for review
Unpolised PR that does the following:
in an effort to keep PRs small, and also to get a quicker sanity-check, I'm going to publish this PR so that this can get your eyes on it @KosmonautX
how to test
exact same functionalities as before, should work the same without issues.