Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-lite/stories): add missing required props for UiButton component configs #7996

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(xo-lite/stories): add missing required props for UiButton component configs #7996

merged 1 commit into from
Sep 20, 2024

Conversation

OlivierFL
Copy link
Collaborator

@OlivierFL OlivierFL commented Sep 18, 2024 •
edited
Loading

Description

Introduced by f969056

The UiButton component usages in the stories weren’t using the required props, causing these stories to break.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@OlivierFL OlivierFL self-assigned this Sep 18, 2024
@OlivierFL OlivierFL requested a review from ByScripts September 18, 2024 13:14
@OlivierFL OlivierFL merged commit 21bd739 into master Sep 20, 2024
1 check passed
@OlivierFL OlivierFL deleted the xo6/fix-stories-button-config branch September 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByScripts ByScripts ByScripts approved these changes

Assignees

@OlivierFL OlivierFL

Labels
XO Lite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierFL @ByScripts