Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-core): update VtsCounter component to v2 #7994

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat(xo-core): update VtsCounter component to v2 #7994

merged 1 commit into from
Sep 24, 2024
+230 −139

Conversation

OlivierFL
Copy link
Collaborator

@OlivierFL OlivierFL commented Sep 18, 2024 •
edited
Loading

Description

  • Add appearance prop ('accent' | 'neutral')
  • Make variant props required (appearance, color and size)
  • Update component usages in XO 6 and XO Lite

Screenshots

counter-v2

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@OlivierFL OlivierFL self-assigned this Sep 18, 2024
@OlivierFL OlivierFL requested a review from ByScripts September 18, 2024 09:13
@OlivierFL OlivierFL force-pushed the xo6/counter-component-v2 branch 3 times, most recently from e39f4e7 to 0874dd0 Compare September 20, 2024 14:44
@OlivierFL OlivierFL changed the title feat(xo-core): update Counter component to v2 feat(xo-core): update VtsCounter component to v2 Sep 20, 2024
@OlivierFL OlivierFL force-pushed the xo6/counter-component-v2 branch from 0874dd0 to 301ad23 Compare September 20, 2024 14:57
@OlivierFL OlivierFL force-pushed the xo6/counter-component-v2 branch from 301ad23 to 0da961e Compare September 23, 2024 13:24
@OlivierFL OlivierFL mentioned this pull request Sep 23, 2024
Merged
@OlivierFL OlivierFL requested review from MathieuRA and removed request for ByScripts September 23, 2024 13:34
@MathieuRA MathieuRA merged commit dbf3d82 into master Sep 24, 2024
1 check passed
@MathieuRA MathieuRA deleted the xo6/counter-component-v2 branch September 24, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA approved these changes

@MelissaFrncJrg MelissaFrncJrg MelissaFrncJrg approved these changes

Assignees

@OlivierFL OlivierFL

Labels
XO Lite XO Web Core XO Web 6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierFL @MathieuRA @MelissaFrncJrg