Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-core): new color scheme + naming from design system #7973

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(web-core): new color scheme + naming from design system #7973

merged 1 commit into from
Sep 10, 2024

Conversation

ByScripts
Copy link
Contributor

@ByScripts ByScripts commented Sep 9, 2024 •
edited
Loading

Description

  • rename _colors.pcss to _colors-legacy.pcss
  • create new _colors.pcss with new naming and colors from DS
  • update existing color usage in *.pcss files
  • add page /dev/colors which displays all available colors

Colors - Light

Colors - Dark

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@ByScripts ByScripts requested a review from OlivierFL September 9, 2024 05:57
@ByScripts ByScripts self-assigned this Sep 9, 2024
@ByScripts ByScripts force-pushed the web-core/update-colors branch from 956b627 to 582dbc1 Compare September 9, 2024 14:00
@ByScripts ByScripts force-pushed the web-core/update-colors branch from 582dbc1 to 29e0c48 Compare September 10, 2024 05:32
@OlivierFL OlivierFL merged commit 790ba9b into master Sep 10, 2024
1 check passed
@OlivierFL OlivierFL deleted the web-core/update-colors branch September 10, 2024 06:35
@OlivierFL OlivierFL mentioned this pull request Sep 10, 2024
Merged
OlivierFL added a commit that referenced this pull request Sep 17, 2024
@OlivierFL
feat(web-stack): replace components CSS color variables with new ones (…
5e11547 
…#7984)

Replace legacy CSS colors variables in components with new ones created by #7973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierFL OlivierFL OlivierFL approved these changes

Assignees

@ByScripts ByScripts

Labels
XO Web Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByScripts @OlivierFL