Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/disks): add icon for empty metadata VDI snapshots #7970

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat(xo-web/disks): add icon for empty metadata VDI snapshots #7970

merged 4 commits into from
Sep 16, 2024

Conversation

MelissaFrncJrg
Copy link
Contributor

Description

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MelissaFrncJrg MelissaFrncJrg marked this pull request as ready for review September 6, 2024 09:33
MathieuRA
MathieuRA reviewed Sep 10, 2024
View reviewed changes
@MathieuRA MathieuRA requested a review from pdonias September 10, 2024 08:52
pdonias
pdonias approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add.

@pdonias pdonias changed the title feat(xo-web): display information when VDI is an empty metadata VDI snapshot feat(xo-web/disks): add icon for empty metadata VDI snapshots Sep 16, 2024
@pdonias pdonias merged commit 385ff21 into master Sep 16, 2024
1 check passed
@pdonias pdonias deleted the sr/Disks/displayMetadataVdiInfo branch September 16, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA left review comments

@pdonias pdonias Awaiting requested review from pdonias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MelissaFrncJrg @pdonias @MathieuRA