Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(defined): create tests for defined() #7967

Merged
merged 6 commits into from
Sep 24, 2024
Merged

test(defined): create tests for defined() #7967

merged 6 commits into from
Sep 24, 2024

Conversation

velvetrevolver
Copy link
Contributor

@velvetrevolver velvetrevolver commented Sep 5, 2024

Review by commits, DO NOT SQUASH.

Create tests for defined()

  • fix for defined() when parameter is an array.

issue XO-163

Copy link
Contributor

@b-Nollet b-Nollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably not a big problem, but if we don't squash the commits then on the first commit the test description lines 10 and 14 don't describe the test correctly.

@velvetrevolver
Copy link
Contributor Author

It's probably not a big problem, but if we don't squash the commits then on the first commit the test description lines 10 and 14 don't describe the test correctly.

Yes, in the first commit the comment doesn't match the test. It's actually to validate the current behavior of defined() so that the test passes, even though this behavior doesn't correspond to what is really expected (hence the fix).

But I can change it if it's an issue.

@b-Nollet
Copy link
Contributor

b-Nollet commented Sep 6, 2024

It's probably not a big problem, but if we don't squash the commits then on the first commit the test description lines 10 and 14 don't describe the test correctly.

Yes, in the first commit the comment doesn't match the test. It's actually to validate the current behavior of defined() so that the test passes, even though this behavior doesn't correspond to what is really expected (hence the fix).

But I can change it if it's an issue.

I don't know if it's worth changing or not, let's get @fbeauchamp's opinion.

@b-Nollet b-Nollet requested a review from fbeauchamp September 6, 2024 08:07
@julien-f julien-f changed the title chore: create tests for defined() test(defined): create tests for defined() Sep 10, 2024
@xen-orchestra/defined/.USAGE.md Outdated Show resolved Hide resolved
@xen-orchestra/defined/.USAGE.md Show resolved Hide resolved
@xen-orchestra/defined/defined.test.mjs Outdated Show resolved Hide resolved
@xen-orchestra/defined/defined.test.mjs Outdated Show resolved Hide resolved
@xen-orchestra/defined/index.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check in the github CI that theses tests are really ran
(last run is :
https://github.com/vatesfr/xen-orchestra/actions/runs/10778481900/job/29889906516 and I don't see defined here since the package.json entry is missing )

@xen-orchestra/defined/defined.test.mjs Outdated Show resolved Hide resolved
@xen-orchestra/defined/index.js Outdated Show resolved Hide resolved
@velvetrevolver velvetrevolver self-assigned this Sep 13, 2024
@velvetrevolver velvetrevolver force-pushed the defined-tests branch 3 times, most recently from f6caca5 to f4b1712 Compare September 18, 2024 07:45
Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLease rebase so that w have one commit for the fix, on one for the test

@julien-f julien-f merged commit b365e4a into master Sep 24, 2024
1 check passed
@julien-f julien-f deleted the defined-tests branch September 24, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants