Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/host): fix "an error has occurred" in host Mode column #7954

Merged
merged 5 commits into from
Sep 16, 2024
Merged

fix(xo-web/host): fix "an error has occurred" in host Mode column #7954

merged 5 commits into from
Sep 16, 2024

Conversation

MelissaFrncJrg
Copy link
Contributor

@MelissaFrncJrg MelissaFrncJrg commented Sep 2, 2024 •
edited
Loading

Description

An error briefly appears in the 'Mode' column on an host's Network tab

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MelissaFrncJrg MelissaFrncJrg marked this pull request as ready for review September 2, 2024 15:39
Danp2
Danp2 reviewed Sep 3, 2024
View reviewed changes
@MathieuRA MathieuRA requested a review from pdonias September 4, 2024 12:19
pdonias
pdonias requested changes Sep 10, 2024
View reviewed changes
@MelissaFrncJrg @pdonias
Update CHANGELOG.unreleased.md
c5c8e35 
Co-authored-by: Pierre Donias <[email protected]>
@pdonias pdonias changed the title fix(xo-web/host): fix 'an error as occured' in host's network tab in 'Mode' column fix(xo-web/host): fix "an error has occurred" in host Mode column Sep 16, 2024
@pdonias pdonias merged commit 04f3a09 into master Sep 16, 2024
1 check passed
@pdonias pdonias deleted the fix/hostNetwork/modesUndefined branch September 16, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@Danp2 Danp2 Danp2 left review comments

@pdonias pdonias pdonias approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MelissaFrncJrg @julien-f @Danp2 @pdonias @MathieuRA