fix(xo-server/rest-api): handle missing content-length

Unconditional cast gave `NaN` instead of `undefined` which broke automatic computation when using VHD.
vatesfr · Sep 18, 2024 · 530c30f · 530c30f
1 parent 4debc0f
commit 530c30f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -22,6 +22,7 @@
 - [Hub/Recipes/Kubernetes] Properly sort versions in selector
 - [Host/Network] Fix `an error has occurred` briefly displaying in 'Mode' column of the host's Network tab (PR [#7954](https://github.com/vatesfr/xen-orchestra/pull/7954))
 - [REST API] Fix VDI export broken in XO 5.96.0 and not completely fixed in XO 5.98.0
+- [REST API] Fix VDI import in VHD format when `Content-Length` is not provided
 
 ### Packages to release
 

diff --git a/packages/xo-server/src/xo-mixins/rest-api.mjs b/packages/xo-server/src/xo-mixins/rest-api.mjs
@@ -1142,7 +1142,7 @@ export default class RestApi {
       '/:collection(srs)/:object/vdis',
       wrap(async (req, res) => {
         const sr = req.xapiObject
-        req.length = +req.headers['content-length']
+        req.length = ifDef(req.headers['content-length'], Number)
 
         const { name_label, name_description, raw } = req.query
         const vdiRef = await sr.$importVdi(req, {