Skip to content

fix(cli): execute crashes with 'str' object has no attribute 'get' #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tengxiaoliu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): execute crashes with 'str' object has no attribute 'get' #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions vastai/cli/commands/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,12 @@ def execute(args):
add_scheduled_job(client, args, json_blob, cli_command, api_endpoint, "PUT", instance_id=args.id)
return

if rj.get("success"):
for i in range(0, 30):
time.sleep(0.3)
url = rj["result_url"]
r2 = req_lib.get(url)
if r2.status_code == 200:
filtered_text = r2.text.replace(rj["writeable_path"], '')
print(filtered_text)
break
else:
print(rj)
# instances_api.execute() already polls the result URL internally and
# returns the command's output as a str on success, or the raw response
# dict on failure (no result_url). The previous code assumed a dict and
# called rj.get("success"), which raised
# "'str' object has no attribute 'get'" on the normal success path.
print(rj)


# ---------------------------------------------------------------------------
Expand Down
Loading