Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Swift 5.8 support and update CI #515

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Drop Swift 5.8 support and update CI #515

merged 4 commits into from
Oct 9, 2024

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Oct 9, 2024

No description provided.

@gwynne gwynne added the semver-patch No public API change. label Oct 9, 2024
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy October 9, 2024 07:59
@gwynne gwynne requested a review from fabianfett as a code owner October 9, 2024 07:59
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.26%. Comparing base (8f7e900) to head (b8e5b3a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   55.08%   60.26%   +5.18%     
==========================================
  Files         127      125       -2     
  Lines       10174     9191     -983     
==========================================
- Hits         5604     5539      -65     
+ Misses       4570     3652     -918

see 5 files with indirect coverage changes

@fabianfett fabianfett mentioned this pull request Oct 9, 2024
Merged
@fabianfett fabianfett merged commit c13a11a into main Oct 9, 2024
9 checks passed
@fabianfett fabianfett deleted the gwynne-patch-1 branch October 9, 2024 08:33
@fabianfett fabianfett added semver-minor Adds new public API. and removed semver-patch No public API change. labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBM MahdiBM MahdiBM approved these changes

@fabianfett fabianfett fabianfett approved these changes

@0xTim 0xTim Awaiting requested review from 0xTim

@ptoffy ptoffy Awaiting requested review from ptoffy

Assignees
No one assigned
Labels
semver-minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwynne @fabianfett @MahdiBM