Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore reporting "Do Not Merge" PRs in Discord #293

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Ignore reporting "Do Not Merge" PRs in Discord #293

wants to merge 9 commits into from
+616 −28

Conversation

MahdiBM
Copy link
Collaborator

@MahdiBM MahdiBM commented Jan 20, 2025

So one can create a PR without spamming the Discord channel

@MahdiBM MahdiBM requested review from 0xTim and gwynne as code owners January 20, 2025 18:54
0xTim
0xTim approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me - I also think we should ignore drafts until they're ready for review and try and enforce this as best we can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MahdiBM @0xTim