Use shared benchmark CI

[MahdiBM]

No description provided.

[github-actions]

Benchmark Report

✅ Pull request has no significant performance differences ✅

Click to expand comparison result

Benchmark check running at 2025-01-18 08:03:54 UTC

The baseline '105/merge' is EQUAL to the defined thresholds.

Click to expand benchmark result

Baseline '105/merge'

Host '1d020e19b26c' with 2 'aarch64' processors with 3 GB memory, running:
#23-Ubuntu SMP Mon Dec  9 23:51:16 UTC 2024

Parser

CollatingParserAllocations_256MiB

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Malloc (total) (K) *	82	82	82	82	82	82	82	1

CollatingParserAllocations_Empty

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Malloc (total) *	8	8	8	8	8	8	8	1

CollatingParserCPUTime_256MiB

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Time (user CPU) (ms) *	540	560	560	570	570	580	580	20

StreamingParserAllocations_256MiB

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Malloc (total) (K) *	82	82	82	82	82	82	82	1

StreamingParserAllocations_Empty

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Malloc (total) *	6	6	6	6	6	6	6	1

StreamingParserCPUTime_256MiB

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Time (user CPU) (ms) *	520	530	530	530	530	560	560	20

Serializer

100xSerializerCPUTime_1024Parts

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Time (user CPU) (ms) *	210	220	220	220	220	220	220	20

SerializerAllocations_1024Parts

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Malloc (total) *	3087	3087	3087	3087	3087	3087	3087	1

SerializerAllocations_Empty

Metric	p0	p25	p50	p75	p90	p99	p100	Samples
Malloc (total) *	4	4	4	4	4	4	4	1

[MahdiBM]

added this. This helps with caching, as well as keeping a history of the benchmarks.

caches have branch-rules. meaning you can only retrieve a cache if it was saved by the current branch, OR the primary branch of the repo.
So the first run of a benchmark event in CI won't have a cache if we don't run benchmarks on push to main.

Though we could workaround this even without push to main. For example manually running the workflow on the main branch so it saves a base cache.

[MahdiBM]

need to change @mmbm-benchmark to @main before merge

[MahdiBM]

keeping the if condition here ... should i move it to the reusable CI?

[0xTim]

No this should probably be in the reusable CI

[gwynne]

Disagree - different repos may not want to use the same conditions.

[MahdiBM]

hmm hard decision. We generally don't add the if condition to the reusable CI so I guess we can keep at that.
I can see it coming back to bite us in either case.