Actually support query logging #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoffy
approved these changes
May 28, 2024
0xTim
approved these changes
May 29, 2024
| @@ -1,126 +1,125 @@ | |||
| import FluentSQL | |||
| import MySQLKit | |||
| import MySQLNIO | |||
| @preconcurrency import MySQLNIO | |||
There was a problem hiding this comment.
No; I've been trying to minimize the changes I make to MySQLNIO (so as to further favor finally finishing the thrice-accursed (literally, not angrily) rewrite that's been in limbo for longer than the entire idea of Fluent 5 🤦♀️.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 98.87% 98.00% -0.88%
==========================================
Files 7 7
Lines 266 250 -16
==========================================
- Hits 263 245 -18
- Misses 3 5 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.6.0
Now supports query logging with the same semantics as the other drivers.
Also cleans up some
Sendableissues and fixes some warnings in the tests.