Skip to content

Conversation

@sliemeobn
Copy link
Collaborator

No description provided.

Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use Vapor's reusable CI IMO:

name: test
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true
on:
  pull_request: { types: [opened, reopened, synchronize, ready_for_review] }
  push: { branches: [ main ] }
  
jobs:
  unit-tests:
    uses: vapor/ci/.github/workflows/run-unit-tests.yml@main
    secrets: inherit

See Vapor's own CI: https://github.com/vapor/vapor/blob/main/.github/workflows/test.yml

@MahdiBM
Copy link

MahdiBM commented Jul 5, 2024

There might be some issues but i'll help you resolve them, if needed ... no sure if a CodeCov token is needed to be added manually, or maybe tsan will make the CI fail ... we can solve them with some 1-line adjustments in the CI file.

@sliemeobn
Copy link
Collaborator Author

sliemeobn commented Jul 5, 2024

@MahdiBM oh, cool, didn't know that existed ; )
let me try...


hmm... on first look it hard-codes swift 5.8 and 5.9, which won't work.
so not sure how to proceed, I think merge this for now and we can sort out a more sophisticated setup later?

@sliemeobn sliemeobn merged commit 5a27f7c into main Jul 5, 2024
@sliemeobn sliemeobn deleted the ci/add-ci branch July 5, 2024 08:11
@MahdiBM
Copy link

MahdiBM commented Jul 5, 2024

@sliemeobn not a problem, it won't run the tests for unsupported Swift versions.

@sliemeobn
Copy link
Collaborator Author

#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants