Open
Conversation
Contributor
Author
|
Damn, the GHA downs again. |
Goooler
force-pushed
the
assert-jar-artifacts
branch
from
54d109c to
cec10f5
Compare
|
|
||
| fun assertThat(actual: ProjectResult): ProjectResultSubject = assertAbout(projectResult()).that(actual) | ||
|
|
||
| fun assertSingleArtifactCommon(result: ProjectResult, artifactExtension: String = "jar", enableSigning: Boolean = true) { |
Collaborator
There was a problem hiding this comment.
Instead of having this on the companion object, can we have this directly on the Subject? So callers do assertThat(result).hasSuccessfullyBuildsSingleCommonArtifact(...). That would fit more with how truth APIs look like.
Goooler
force-pushed
the
assert-jar-artifacts
branch
from
cec10f5 to
31483a7
Compare
Goooler
force-pushed
the
assert-jar-artifacts
branch
from
31483a7 to
ce7305b
Compare
Goooler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #1212.