Skip to content

fix(core): fixed subscribeProxies function#5

Merged
dai-shi merged 3 commits intovaltiojs:mainfrom
overthemike:fix-subscribe-proxies
Jan 12, 2026
Merged

fix(core): fixed subscribeProxies function#5
dai-shi merged 3 commits intovaltiojs:mainfrom
overthemike:fix-subscribe-proxies

Conversation

@overthemike
Copy link
Contributor

fixes #4

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 11, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@overthemike
Copy link
Contributor Author

Actually I forgot to add a test for these scenarios. I'll add those now.

@overthemike overthemike changed the title Fix subscribe proxies fix(core): fixed subscribeProxies function Jan 11, 2026
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner. Thanks!

@dai-shi dai-shi merged commit 4ded45d into valtiojs:main Jan 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Primitive value updates do not trigger watch

2 participants