Skip to content

Conversation

@enjoy-binbin
Copy link
Member

This crash was introduced in #2877, we will crash when there is no replication backlog.

This crash was introduced in valkey-io#2877, we will crash when there is
no replication backlog.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin
Copy link
Member Author

Sorry for this mistake, CI reported the crash before, but I didn't notice it at the time.

@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.45%. Comparing base (a087cc1) to head (9baff20).
⚠️ Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/replication.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2886      +/-   ##
============================================
+ Coverage     72.43%   72.45%   +0.02%     
============================================
  Files           128      128              
  Lines         70485    70487       +2     
============================================
+ Hits          51055    51072      +17     
+ Misses        19430    19415      -15     
Files with missing lines Coverage Δ
src/replication.c 85.94% <66.66%> (+0.04%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enjoy-binbin enjoy-binbin merged commit 4a0e20b into valkey-io:unstable Dec 1, 2025
56 checks passed
@enjoy-binbin enjoy-binbin deleted the fix_test branch December 1, 2025 02:20
@sarthakaggarwal97
Copy link
Contributor

This is where Merge Queue (#2820) would have helped as well.

zhijun42 pushed a commit to zhijun42/valkey that referenced this pull request Dec 2, 2025
…io#2886)

This crash was introduced in valkey-io#2877, we will crash when there is no
replication backlog.

Signed-off-by: Binbin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants