Go: batch - add commands #4005
Merged
Go: batch - add commands #4005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Edward Liang <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
…n-cmds Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jbrinkman
reviewed
May 28, 2025
| // | ||
| // Command Response: | ||
| // | ||
| // The returned value for the custom command. |
There was a problem hiding this comment.
The Command Response docs seem a little misleading. Each command returns *T. It is the executeBatch that returns values. Maybe there should be a preamble like "Command Responses are returned when the Batch is executed."
There was a problem hiding this comment.
We should apply this change to all clients - we can do this in another PR.
jbrinkman
reviewed
May 28, 2025
jbrinkman
reviewed
May 28, 2025
jbrinkman
reviewed
May 28, 2025
| // [valkey.io]: https://valkey.io/commands/zunion/ | ||
| func (b *BaseBatch[T]) ZUnionWithScores( | ||
| keysOrWeightedKeys options.KeysOrWeightedKeys, | ||
| zUnionOptions options.ZUnionOptions, |
There was a problem hiding this comment.
The baseClient implementation has zUnionOptions as a pointer
There was a problem hiding this comment.
There is an error on client side actually, I created a task to fix this.
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #3547, #2791, #3484
Checklist
Before submitting the PR make sure the following are checked: