Skip to content

Go: Add otel support #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jun 3, 2025
Merged

Go: Add otel support #3932

merged 28 commits into from
Jun 3, 2025

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented May 21, 2025 •
edited
Loading

old PR closed to re-target at main: #3834

Issue link

This Pull Request is linked to issue (URL): #3531

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@adarovadya adarovadya mentioned this pull request May 22, 2025
Closed
6 tasks
@tjzhang-BQ tjzhang-BQ requested a review from adarovadya May 23, 2025 23:05
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review May 23, 2025 23:12
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner May 23, 2025 23:12
alexey-temnikov
alexey-temnikov reviewed May 26, 2025
View reviewed changes
Copy link
Collaborator

@alexey-temnikov alexey-temnikov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjzhang-BQ thank you for the PR!

alexey-temnikov
alexey-temnikov reviewed May 26, 2025
View reviewed changes
@adarovadya
Copy link
Collaborator

Has @jonathanl-bq already reviewed the FFI sections?

@tjzhang-BQ
Copy link
Collaborator Author

yes, comments from Jonathan have been addressed

adarovadya
adarovadya reviewed Jun 2, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 2, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 2, 2025
View reviewed changes
@tjzhang-BQ
update test case
6bd603a 
Signed-off-by: TJ Zhang <[email protected]>
@tjzhang-BQ tjzhang-BQ merged commit 8a3ef14 into main Jun 3, 2025
22 of 23 checks passed
adarovadya
adarovadya reviewed Jun 3, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 3, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 3, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 3, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 3, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 3, 2025
View reviewed changes
adarovadya
adarovadya reviewed Jun 3, 2025
View reviewed changes
@tjzhang-BQ tjzhang-BQ mentioned this pull request Jun 3, 2025
Merged
6 tasks
@tjzhang-BQ
Copy link
Collaborator Author

Addressed the additional comments after merge in a new PR: #4078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-temnikov alexey-temnikov alexey-temnikov left review comments

@adarovadya adarovadya adarovadya left review comments

@MikeMwita MikeMwita MikeMwita left review comments

@jonathanl-bq jonathanl-bq jonathanl-bq approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

Assignees
No one assigned
Labels
go golang wrapper Telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tjzhang-BQ @adarovadya @alexey-temnikov @jonathanl-bq @Yury-Fridlyand @MikeMwita @yipin-chen @prateek-kumar-improving