-
Notifications
You must be signed in to change notification settings - Fork 21
Spelling #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Spelling #37
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ec69363
spelling: ; otherwise,
jsoref 6cce5a0
spelling: attempts
jsoref 1113791
spelling: cannot
jsoref 0f42071
spelling: change
jsoref dd66d1d
spelling: commands
jsoref 635c04d
spelling: correct
jsoref 0478a03
spelling: current
jsoref 5265478
spelling: emitted
jsoref 620c34a
spelling: equals
jsoref af97a3c
spelling: fall back
jsoref 29624d5
spelling: helpful
jsoref 134f413
spelling: id
jsoref 25e33d0
spelling: instead
jsoref a75f25a
spelling: integer
jsoref 7f4571d
spelling: maintenance
jsoref db2831d
spelling: pipeline
jsoref 31e9606
spelling: there are
jsoref 04ba44d
spelling: timeout
jsoref e108079
spelling: transaction
jsoref b4aa6a4
spelling: usecases
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is auto-generated, these changes will be overwrite.
needs to port the spelling fixes to https://github.com/valkey-io/valkey/tree/57b176169d2c869d14dc4908674ffbb8b28b39cc/src/commands
@jsoref can you fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/valkey-io/valkey/blob/57b176169d2c869d14dc4908674ffbb8b28b39cc/src/commands/shutdown.json
https://github.com/valkey-io/valkey/blob/57b176169d2c869d14dc4908674ffbb8b28b39cc/src/commands/spop.json
https://github.com/valkey-io/valkey/blob/57b176169d2c869d14dc4908674ffbb8b28b39cc/src/commands/srandmember.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be somewhere in https://github.com/valkey-io/valkey/pulls/jsoref