Tolerate having no connected nodes in ConnectionPool.getSampleInstance()
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Slota <[email protected]>
Signed-off-by: Martin Slota <[email protected]>
martinslota
force-pushed
the
martinslota/tolerate-undefined-in-getSampleInstance
branch
from
ee736e4 to
27bcab5
Compare
|
You should also add it to getNodes, it also changed behavior after #5 |
|
@gurgunday I considered making that change as well, but I believe it is unnecessary because in Were you able to provoke a similar error from |
martinslota
deleted the
martinslota/tolerate-undefined-in-getSampleInstance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: The fix in this PR has been combined with another (very likely unnecessary) change in #34 and merged to
main.This PR addresses the immediate error reported in #31 by fixing an oversight from #5.
However, this fix may not be sufficient to address #31 overall.