Add list and clone interactive list command #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmcd
reviewed
Apr 13, 2025
| const { ownerName, projectName } = parseProjectUri( | ||
| projectUri, | ||
| user.username!, | ||
| async (_, projectUri?: string, cloneDir?: string, branchName?: string) => { |
There was a problem hiding this comment.
can we detect if it's a tty before we do interactive stuff? ideally we would also not run spinners and other stuff that clears terminal lines if we're not in a terminal
There was a problem hiding this comment.
I agree! This is something that will probably require a more fundamental change (I was working on a stubbed Kia previously, but I think that's not the best solution).
I'd like to save that for a later PR since this is the case in many different situations.
For the MVP I think it's best to focus on the interactive experience. Is it OK if we wait on this?
maxmcd
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/1020432421243592714/1347197236341374976/1360024923359416580