Add two optional options that are used to skip dialogs #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dialog boxes. Skipping both will result in a fully transparent experience for the user.
vaenow
reviewed
Apr 9, 2018
| @@ -140,17 +140,31 @@ private void compareVersions() { | |||
| int versionCodeLocal = version.getLocal(); | |||
| int versionCodeRemote = version.getRemote(); | |||
|
|
|||
| boolean skipPromptDialog = false; | |||
| try { | |||
| skipPromptDialog = options.getBoolean("skipPromptDialog"); | |||
There was a problem hiding this comment.
Suggest you move skipPromptDialog / skipProgressDialog into Constants
|
I have reviewed your code, it looks good. Thank you @loban for your a lot of contributions 🍻 |
|
You're welcome! Glad to help. This plugin has been very useful in our current project. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of the plugin (including me) may want to create a seamless experience for their users and not show any dialog prompts. This patch allows two additional options when calling the checkAppUpdate() function.
This was inspired by pull request #78, and incorporates the request to make it an optional feature.