FIx waku double message issue #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for c7a0a7bClick to view benchmark
|
Benchmark for 0a19c11Click to view benchmark
|
- Restructured main application to separate server and Waku node initialization - Added more detailed logging for Waku node setup and connection process - Updated Cargo.toml to use underscore naming convention and update Alloy dependency - Modified Dockerfile to simplify build process - Improved error handling and task management in main application flow
- Updated package name in Cargo.toml to use hyphen instead of underscore for consistency. - Simplified dependency paths for Waku bindings in Cargo.toml files across the project. - Modified Dockerfile to streamline the build process by removing unnecessary release flags. - Enhanced README with updated environment variable instructions for better clarity. - Improved frontend button structure for better user interaction. - Cleaned up unused code in Waku actor and related tests, enhancing maintainability.
- Added comments to clarify that the Waku node is auto-subscribing to the pubsub topic and that explicit subscription is unnecessary due to this behavior. - Documented the limitation regarding subscription checks in Waku, referencing the related issue for better context.
…mmenting out the library section. This streamlines the configuration and focuses on Rust dependencies.
- Introduced a new benchmark configuration in Cargo.toml for `group_flow_benchmark`. - Updated docker-compose.yml to include `PEER_ADDRESSES` environment variable. - Enhanced README with instructions for setting `PEER_ADDRESSES` for node connections. - Modified main.rs to parse and utilize peer addresses for Waku node connections, improving network configuration flexibility.
…process - Added a library section in Cargo.toml to specify bench settings. - Modified Dockerfile to create necessary source files and streamline the build process by removing redundant commands. - Updated main.rs to improve error handling for peer address configuration.
…erfile to streamline build process, and disable CI benchmark jobs in workflow configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.