fix: move CSS imports from @Theme to bootstrap JS file #22518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
caalador
requested changes
Oct 20, 2025
| entryPoint.getModulesDevelopmentOnly() | ||
| .addAll(classInfo.modulesDevelopmentOnly); | ||
| if (classInfo.loadCss) { | ||
| if (classInfo.loadCss || activeTheme |
There was a problem hiding this comment.
the loadCss is always false for all theme files and activeTheme now lets through all theme files even with loadCss false. So the flag can be fully removed.
| Assert.assertEquals( | ||
| "Project contains 4 css injections to document and all should be hashed", | ||
| 4l, getCommandExecutor().executeScript( | ||
| "Project contains 2 css injections to document and all should be hashed", |
There was a problem hiding this comment.
What global css has embedded applications lost?
|
|
||
| protected <T> List<String> merge(Map<T, List<String>> css) { | ||
| protected <T> List<String> merge(Map<T, List<String>> outputFiles) { | ||
| // Ignore app shell imports and definitions for bundle build detection, |
There was a problem hiding this comment.
Shouldn't app shell imports also be taken into account by flow as they are not added to the general imports anymore even though they were there before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22517