Test auto format #22454
Draft
Test auto format #22454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
flow-spotless-update
branch
from
d13ef9c to
58cd01c
Compare
Artur-
force-pushed
the
Artur--patch-16
branch
from
561d442 to
105c2bb
Compare
Artur-
force-pushed
the
flow-spotless-update
branch
from
58cd01c to
52aec19
Compare
Artur-
force-pushed
the
Artur--patch-16
branch
from
89a7a12 to
aead6ee
Compare
Artur-
force-pushed
the
Artur--patch-16
branch
2 times, most recently
from
06161db to
38db162
Compare
- Modified formatter workflow to automatically commit and push formatting changes - Added infinite loop detection by checking if last commit author was github-actions bot - Changed permissions to allow contents: write for pushing commits - Updated validation workflow to run after formatter completes - Added conditional execution to skip validation if formatter committed changes - Formatter will retrigger after auto-commit to verify formatting is correct 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Merged formatter.yml into validation.yml as a single workflow - Formatter runs first on pull_request_target events - If formatting changes are committed, workflow stops and retriggers - On second run, detects bot commit and skips formatting, proceeds to tests - Build and test jobs only run if formatter succeeds or is skipped - Prevents infinite loops by detecting bot commits and not formatting again 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Removed workflow stop after formatter commits changes - Pass new commit SHA to all downstream jobs (build, unit-tests, it-tests, test-results) - All jobs now checkout the formatted code using new_sha output from formatter - Validation runs in same workflow after formatting, no separate trigger needed - Fallback to original HEAD_SHA when formatter is skipped (push to main branches) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Require VAADIN_BOT_TOKEN secret for formatter workflow - Use PAT instead of GITHUB_TOKEN to push commits (enables workflow triggers) - Fail build if token is not configured - Stop workflow after formatter commits (new workflow will be triggered) - On second run, formatter detects bot commit and skips, validation proceeds - Revert new_sha passing logic (not needed with PAT approach) To set up: 1. Create GitHub PAT with repo and workflow permissions 2. Add as repository secret named VAADIN_BOT_TOKEN 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Artur-
force-pushed
the
flow-spotless-update
branch
from
b217255 to
347f208
Compare
Artur-
force-pushed
the
Artur--patch-16
branch
2 times, most recently
from
f429432 to
77ff649
Compare
Artur-
force-pushed
the
flow-spotless-update
branch
from
a1b95ee to
347f208
Compare
Artur-
force-pushed
the
Artur--patch-16
branch
from
77ff649 to
2203055
Compare
Artur-
force-pushed
the
flow-spotless-update
branch
from
ff69418 to
37e8c75
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.