Skip to content

refactor: Throw when data provider returns more items than requested - #22310

Merged
mshabarov merged 3 commits into
mainfrom
throw-when-returned-more-items-than-requested
Dec 10, 2025
Merged

mshabarov merged 3 commits into
mainfrom
throw-when-returned-more-items-than-requested

Merge branch 'main' into throw-when-returned-more-items-than-requested

d275a18
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Dec 9, 2025 in 1m 3s

Annotations

Check failure on line 76 in vaadin-dev-server/src/test/java/com/vaadin/base/devserver/AbstractDevServerRunnerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IjrG-qy-rVn9jd_&open=AZsD7IjrG-qy-rVn9jd_&pullRequest=22310

Check warning on line 692 in flow-server/src/test/java/com/vaadin/flow/server/frontend/AbstractUpdateImportsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.net.URISyntaxException', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IdqG-qy-rVn9jbX&open=AZsD7IdqG-qy-rVn9jbX&pullRequest=22310

Check warning on line 1584 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jcW&open=AZsD7IhHG-qy-rVn9jcW&pullRequest=22310

Check warning on line 1589 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jcY&open=AZsD7IhHG-qy-rVn9jcY&pullRequest=22310

Check warning on line 400 in signals/src/test/java/com/vaadin/signals/ReferenceSignalTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'signal::value'.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IiLG-qy-rVn9jdx&open=AZsD7IiLG-qy-rVn9jdx&pullRequest=22310

Check warning on line 260 in flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskRunPnpmInstallTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this String concatenation with Text block.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IYdG-qy-rVn9jaP&open=AZsD7IYdG-qy-rVn9jaP&pullRequest=22310

Check warning on line 145 in flow-server/src/test/java/com/vaadin/flow/server/startup/AbstractRouteRegistryInitializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IeoG-qy-rVn9jbj&open=AZsD7IeoG-qy-rVn9jbj&pullRequest=22310

Check warning on line 148 in flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeTasksExecutionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()".

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IcQG-qy-rVn9ja5&open=AZsD7IcQG-qy-rVn9ja5&pullRequest=22310

Check warning on line 1868 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jdI&open=AZsD7IhHG-qy-rVn9jdI&pullRequest=22310

Check failure on line 392 in vaadin-spring/src/test/java/com/vaadin/flow/spring/springnative/ClientCallableAotProcessorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IigG-qy-rVn9jd6&open=AZsD7IigG-qy-rVn9jd6&pullRequest=22310

Check warning on line 1963 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Swap these 2 arguments so they are in the correct order: expected value, actual value.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jdW&open=AZsD7IhHG-qy-rVn9jdW&pullRequest=22310

Check warning on line 126 in flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeTestComponents.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "include"; it is deprecated.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IckG-qy-rVn9ja-&open=AZsD7IckG-qy-rVn9ja-&pullRequest=22310

Check warning on line 1907 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jdP&open=AZsD7IhHG-qy-rVn9jdP&pullRequest=22310

Check warning on line 2175 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jde&open=AZsD7IhHG-qy-rVn9jde&pullRequest=22310

Check warning on line 144 in flow-server/src/test/java/com/vaadin/flow/server/frontend/AbstractNodeUpdatePackagesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "DEP_NAME_FLOW_DEPS"; it is deprecated.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IaXG-qy-rVn9jae&open=AZsD7IaXG-qy-rVn9jae&pullRequest=22310

Check warning on line 2068 in flow-server/src/test/java/com/vaadin/flow/server/frontend/BundleValidationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 3 tests with a single Parameterized one.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IZuG-qy-rVn9jaa&open=AZsD7IZuG-qy-rVn9jaa&pullRequest=22310

Check warning on line 250 in flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskGenerateTsConfigTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'AbstractTaskClientGenerator::log'.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IbMG-qy-rVn9jav&open=AZsD7IbMG-qy-rVn9jav&pullRequest=22310

Check warning on line 208 in flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeTestComponents.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this String concatenation with Text block.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IckG-qy-rVn9jbI&open=AZsD7IckG-qy-rVn9jbI&pullRequest=22310

Check failure on line 339 in vaadin-spring/src/test/java/com/vaadin/flow/spring/springnative/ClientCallableAotProcessorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IigG-qy-rVn9jd2&open=AZsD7IigG-qy-rVn9jd2&pullRequest=22310

Check warning on line 1744 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "resource".

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jc0&open=AZsD7IhHG-qy-rVn9jc0&pullRequest=22310

Check failure on line 273 in flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskGenerateReactFilesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IeCG-qy-rVn9jbb&open=AZsD7IeCG-qy-rVn9jbb&pullRequest=22310

Check warning on line 1676 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jcr&open=AZsD7IhHG-qy-rVn9jcr&pullRequest=22310

Check warning on line 1402 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jcI&open=AZsD7IhHG-qy-rVn9jcI&pullRequest=22310

Check warning on line 1833 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IhHG-qy-rVn9jdE&open=AZsD7IhHG-qy-rVn9jdE&pullRequest=22310

Check warning on line 403 in flow-server/src/test/java/com/vaadin/flow/server/frontend/AbstractNodeUpdatePackagesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "classFinder" which hides the field declared at line 73.

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZsD7IaXG-qy-rVn9jal&open=AZsD7IaXG-qy-rVn9jal&pullRequest=22310