Skip to content

fix: add manual validation property to custom field #7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ugur-vaadin
Copy link
Contributor

Description

This PR sets manualValidation property on the CustomField in order to keep the validation in sync. Based on the approach in the PR #6792.

Possibly fixes other issues around CustomField validation.

Fixes #7483

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can now also remove FieldValidationUtil from CustomField added in #3277.
Also it would be good to have some IT that would verify the improvement.

@ugur-vaadin ugur-vaadin marked this pull request as draft June 6, 2025 11:32
@ugur-vaadin ugur-vaadin marked this pull request as ready for review June 9, 2025 23:05
@ugur-vaadin ugur-vaadin force-pushed the fix-add-manual-validation-property-to-custom-field branch from f249325 to 5491868 Compare June 9, 2025 23:06
@ugur-vaadin ugur-vaadin force-pushed the fix-add-manual-validation-property-to-custom-field branch from 5491868 to 404ea03 Compare June 19, 2025 11:12
@ugur-vaadin
Copy link
Contributor Author

I suppose we can now also remove FieldValidationUtil from CustomField added in #3277. Also it would be good to have some IT that would verify the improvement.

Removed FieldValidationUtil and added an IT.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with disappearing ValidationError (BlurListener?) when combining DateTimeField+x in CustomField?
3 participants