feat: Improve MenuBarElement #7338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Apr 30, 2025
...-bar-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarElement.java
Outdated
Show resolved
Hide resolved
...-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarItemElement.java
Outdated
Show resolved
Hide resolved
...-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarItemElement.java
Outdated
Show resolved
Hide resolved
…/java/com/vaadin/flow/component/menubar/testbench/MenuBarItemElement.java Co-authored-by: Sergey Vinogradov <[email protected]>
…/java/com/vaadin/flow/component/menubar/testbench/MenuBarItemElement.java Co-authored-by: Sergey Vinogradov <[email protected]>
…/java/com/vaadin/flow/component/menubar/testbench/MenuBarElement.java Co-authored-by: Sergey Vinogradov <[email protected]>
vursen
reviewed
May 1, 2025
...estbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarButtonElement.java
Show resolved
Hide resolved
web-padawan
reviewed
May 5, 2025
...-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarItemElement.java
Show resolved
Hide resolved
vursen
reviewed
May 6, 2025
...-bar-testbench/src/main/java/com/vaadin/flow/component/menubar/testbench/MenuBarElement.java
Outdated
Show resolved
Hide resolved
vursen
reviewed
May 6, 2025
Comment on lines
103
to
106
| if (button == null) { | ||
| return null; | ||
| } | ||
| return button.getSubMenu(); |
There was a problem hiding this comment.
Suggested change
| if (button == null) { | |
| return null; | |
| } | |
| return button.getSubMenu(); | |
| return button != null ? button.getSubMenu() : null; |
…/java/com/vaadin/flow/component/menubar/testbench/MenuBarElement.java
…/java/com/vaadin/flow/component/menubar/testbench/MenuBarElement.java
vursen
approved these changes
May 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7362
Fixes #7363