fix: prevent initialValue from becoming emptyValue (#7030) (#7031)

Co-authored-by: Sergey Vinogradov <[email protected]>
vaadin · Jan 13, 2025 · dec84c9 · dec84c9
1 parent ce1b925
commit dec84c9
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 2 deletions.
diff --git a/...aadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java b/...aadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java
@@ -249,7 +249,7 @@ public DatePicker(LocalDate initialDate) {
      * @see #setValue(Object)
      */
     private DatePicker(LocalDate initialDate, boolean isInitialValueOptional) {
-        super("value", initialDate, String.class, PARSER, FORMATTER);
+        super("value", null, String.class, PARSER, FORMATTER);
 
         // Initialize property value unless it has already been set from a
         // template

diff --git a/...n-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java b/...n-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java
@@ -88,6 +88,18 @@ public void setInitialValue() {
                 picker.getElement().getProperty("value"));
     }
 
+    @Test
+    public void emptyValueIsNull() {
+        DatePicker picker = new DatePicker();
+        Assert.assertNull(picker.getEmptyValue());
+    }
+
+    @Test
+    public void setInitialValue_emptyValueIsNull() {
+        DatePicker picker = new DatePicker(LocalDate.of(2018, 4, 25));
+        Assert.assertNull(picker.getEmptyValue());
+    }
+
     @Test
     public void updatingToNullValue_displaysEmptyString() {
         DatePicker picker = new DatePicker();

diff --git a/...aadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java b/...aadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java
@@ -218,7 +218,7 @@ public TimePicker(LocalTime time) {
      *            ignored and the initial value is set
      */
     private TimePicker(LocalTime time, boolean isInitialValueOptional) {
-        super("value", time, String.class, PARSER, FORMATTER);
+        super("value", null, String.class, PARSER, FORMATTER);
 
         // Initialize property value unless it has already been set from a
         // template

diff --git a/...-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java b/...-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java
@@ -79,6 +79,18 @@ public void timePicker_basicCases() {
         assertEquals(LocalTime.of(7, 40), picker.getValue());
     }
 
+    @Test
+    public void emptyValueIsNull() {
+        TimePicker picker = new TimePicker();
+        Assert.assertNull(picker.getEmptyValue());
+    }
+
+    @Test
+    public void setInitialValue_emptyValueIsNull() {
+        TimePicker picker = new TimePicker(LocalTime.of(5, 30));
+        Assert.assertNull(picker.getEmptyValue());
+    }
+
     @Test
     public void timePicker_nullValue() {
         TimePicker timePicker = new TimePicker();