-
Notifications
You must be signed in to change notification settings - Fork 215
docs: add Map component style variants and properties #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Language ReviewThe file "Map" has no modifications that require improvements. |
|
|
||
| include::../_styling-section-theming-props.adoc[tag=style-properties] | ||
|
|
||
| [cols="2,1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several icons are not in base styles / Aura:
- --vaadin-map-icon-fullscreen
- --vaadin-map-icon-close
- --vaadin-map-icon-compass
- --vaadin-map-icon-overview-map-expand
Though it looks like they should be, given that --vaadin-map-icon-overview-map-collapse for example is in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, created a PR: vaadin/web-components#10576
| --- | ||
| = Map Styling | ||
|
|
||
| == Style Variants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Maybe add an intro sentence as in other component pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
MapThemeBorderlessexample toMapNoBorderand changed the variant,See also vaadin/web-components#10573 for the Lumo style properties change.