Skip to content

Conversation

@web-padawan
Copy link
Member

  • Added missing Styling page for the Map component and moved theme variant section,
  • Renamed MapThemeBorderless example to MapNoBorder and changed the variant,

See also vaadin/web-components#10573 for the Lumo style properties change.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

AI Language Review

The file "Map" has no modifications that require improvements.


include::../_styling-section-theming-props.adoc[tag=style-properties]

[cols="2,1"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several icons are not in base styles / Aura:

  • --vaadin-map-icon-fullscreen
  • --vaadin-map-icon-close
  • --vaadin-map-icon-compass
  • --vaadin-map-icon-overview-map-expand

Though it looks like they should be, given that --vaadin-map-icon-overview-map-collapse for example is in there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, created a PR: vaadin/web-components#10576

---
= Map Styling

== Style Variants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe add an intro sentence as in other component pages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@web-padawan web-padawan removed the request for review from DiegoCardoso December 4, 2025 14:04
@web-padawan web-padawan merged commit e7fd2b4 into main Dec 4, 2025
4 checks passed
@web-padawan web-padawan deleted the docs/map-styling branch December 4, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants