Skip to content

Conversation

ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Sep 23, 2025

Updates Tree Grid articles and examples based on the HierarchyFormat changes.

NOTE: Targets the branch for the scrollToItem section PR.

Closes #4529

@ugur-vaadin ugur-vaadin force-pushed the tree-grid-article-update branch from 60dd532 to 9419a42 Compare September 23, 2025 06:59
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

AI Language Review

  • PopoverPositioning.java: No issues detected.

  • TreeGridScrollToItem.java: The change from new TreeDataProvider<>(treeData) to new TreeDataProvider<>(treeData, HierarchicalDataProvider.HierarchyFormat.FLATTENED) is accurate and improves performance by maintaining the scroll position. No issues with this modification.

  • TreeGridDragDrop.java: The addition of the TreeGridDragDrop class, including the setup for drag-and-drop functionality and use of HierarchicalDataProvider.HierarchyFormat.FLATTENED, seems correctly implemented. No issues detected.

  • tree-grid-drag-drop.ts: The changes appear to improve the drag-and-drop logic in the example code. The modifications encourage better usage practices by avoiding grid.clearCache(), although this is marked not recommended. No issues found.

Overall, the changes improve functionality and performance, addressing specific use cases like drag-and-drop operations in hierarchical data components.

@ugur-vaadin ugur-vaadin force-pushed the tree-grid-article-update branch 2 times, most recently from 8f0c7f6 to 125683d Compare October 10, 2025 11:30
@ugur-vaadin ugur-vaadin requested a review from vursen October 10, 2025 12:38
@ugur-vaadin ugur-vaadin marked this pull request as ready for review October 10, 2025 12:38
Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the scrollToItem documentation in a separate PR that doesn't introduce the flattened hierarchy yet.

@ugur-vaadin ugur-vaadin force-pushed the tree-grid-article-update branch from d1c15c0 to d318ba5 Compare October 15, 2025 10:42
@ugur-vaadin
Copy link
Contributor Author

Let's add the scrollToItem documentation in a separate PR that doesn't introduce the flattened hierarchy yet.

Extracted scrollToItem section to another PR.

@ugur-vaadin ugur-vaadin force-pushed the tree-grid-article-update branch from d318ba5 to 22859fa Compare October 15, 2025 11:05
@ugur-vaadin ugur-vaadin changed the base branch from main to docs-add-tree-grid-scroll-to-item-section October 15, 2025 11:06
@ugur-vaadin ugur-vaadin force-pushed the docs-add-tree-grid-scroll-to-item-section branch from a66915c to bbd65ec Compare October 15, 2025 13:13
Base automatically changed from docs-add-tree-grid-scroll-to-item-section to main October 15, 2025 13:14
@ugur-vaadin ugur-vaadin force-pushed the tree-grid-article-update branch from 22859fa to 8c388bb Compare October 15, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants