Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ apply plugin: 'com.android.application'

android {
compileSdk 33
buildFeatures {
buildConfig true
}
defaultConfig {
applicationId "me.ghui.v2er"
minSdkVersion 27
Expand Down Expand Up @@ -70,21 +73,21 @@ android {

dependencies {
implementation fileTree(include: ['*.jar'], dir: 'libs')
androidTestImplementation('androidx.test.espresso:espresso-core:3.1.0', {
androidTestImplementation('androidx.test.espresso:espresso-core:3.6.1', {
exclude group: 'com.android.support', module: 'support-annotations'
exclude group: 'com.google.code.findbugs'
})
testImplementation 'junit:junit:4.13.2'

implementation 'androidx.appcompat:appcompat:1.3.0'
implementation 'androidx.appcompat:appcompat:1.6.1'
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appcompat version (1.6.1) does not match the intended bump to 1.7.1 in the PR description; please update to 1.7.1.

Suggested change
implementation 'androidx.appcompat:appcompat:1.6.1'
implementation 'androidx.appcompat:appcompat:1.7.1'

Copilot uses AI. Check for mistakes.
implementation 'com.google.android.material:material:1.3.0'
implementation 'androidx.recyclerview:recyclerview:1.2.0'
implementation 'androidx.recyclerview:recyclerview:1.3.2'
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recyclerview version (1.3.2) does not match the intended bump to 1.4.0; please update to 1.4.0.

Suggested change
implementation 'androidx.recyclerview:recyclerview:1.3.2'
implementation 'androidx.recyclerview:recyclerview:1.4.0'

Copilot uses AI. Check for mistakes.
implementation 'androidx.cardview:cardview:1.0.0'
implementation 'androidx.browser:browser:1.3.0'
implementation 'androidx.browser:browser:1.7.0'
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The browser version (1.7.0) does not match the intended bump to 1.8.0; please update to 1.8.0.

Suggested change
implementation 'androidx.browser:browser:1.7.0'
implementation 'androidx.browser:browser:1.8.0'

Copilot uses AI. Check for mistakes.
implementation 'androidx.palette:palette:1.0.0'
implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constraintlayout version (2.1.4) does not match the intended bump to 2.2.1; please update to 2.2.1.

Suggested change
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
implementation 'androidx.constraintlayout:constraintlayout:2.2.1'

Copilot uses AI. Check for mistakes.
implementation 'com.google.android.flexbox:flexbox:3.0.0'
implementation "androidx.annotation:annotation:1.2.0"
implementation "androidx.annotation:annotation:1.7.1"
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The annotation version (1.7.1) does not match the intended bump to 1.9.1; please update to 1.9.1.

Suggested change
implementation "androidx.annotation:annotation:1.7.1"
implementation "androidx.annotation:annotation:1.9.1"

Copilot uses AI. Check for mistakes.
// JSR305 annotations for javax.annotation
implementation 'com.google.code.findbugs:jsr305:3.0.2'
// 3rd part Dependencies...
Expand Down
10 changes: 6 additions & 4 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true
#Sat Mar 04 11:07:15 CST 2017
org.gradle.jvmargs=-Xmx1536M \
org.gradle.jvmargs=-Xmx2048m -XX:MaxMetaspaceSize=512m \
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For consistency with other JVM args, consider using uppercase -Xmx2048M.

Suggested change
org.gradle.jvmargs=-Xmx2048m -XX:MaxMetaspaceSize=512m \
org.gradle.jvmargs=-Xmx2048M -XX:MaxMetaspaceSize=512m \

Copilot uses AI. Check for mistakes.
--add-exports=java.base/sun.nio.ch=ALL-UNNAMED \
--add-opens=java.base/java.lang=ALL-UNNAMED \
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED \
Expand All @@ -22,10 +22,12 @@ org.gradle.jvmargs=-Xmx1536M \
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
systemProp.http.proxyPort=6153
# systemProp.http.proxyPort=6153

Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] If this proxy setting is no longer needed, consider removing the commented line instead of retaining it.

Suggested change
# systemProp.http.proxyPort=6153

Copilot uses AI. Check for mistakes.
android.useAndroidX=true
android.enableJetifier=true
android.defaults.buildfeatures.buildconfig=true
android.nonTransitiveRClass=false
android.nonFinalResIds=false
android.nonFinalResIds=false
org.gradle.parallel=true
org.gradle.caching=true
org.gradle.configuration-cache=true
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists