Skip to content

fix: simplify version display #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graycreate merged 1 commit into from
Dec 27, 2025
Merged

fix: simplify version display #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/me/ghui/v2er/module/settings/SettingFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public void onCreate(Bundle savedInstanceState) {

// App version
Preference versionPref = findPreference(getString(R.string.pref_key_app_version));
versionPref.setSummary(Utils.getVersionName() + " (" + Utils.getVersionCode() + ")");
versionPref.setSummary(Utils.getVersionName());
}

Comment on lines +103 to 105
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change does not achieve the stated goal of showing only the version name. Looking at the implementation of Utils.getVersionName() (line 347 in Utils.java), it returns packageInfo.versionName + "." + packageInfo.versionCode, which means the version code is still included in the display. The version code was previously shown in parentheses (e.g., "2.3.13 (56)"), and now it will be shown as a dot-separated suffix (e.g., "2.3.13.56"). To truly show only the version name without the version code, the Utils.getVersionName() method needs to be modified to return only packageInfo.versionName, or a separate method should be used here.

Suggested change
versionPref.setSummary(Utils.getVersionName());
}
versionPref.setSummary(getAppVersionNameOnly());
}
/**
* Returns only the version name portion, stripping any appended version code
* that may be added by {@link Utils#getVersionName()} (e.g. "2.3.13.56" -> "2.3.13").
*/
private String getAppVersionNameOnly() {
String fullVersion = Utils.getVersionName();
if (fullVersion == null || fullVersion.isEmpty()) {
return fullVersion;
}
int lastDot = fullVersion.lastIndexOf('.');
if (lastDot > 0) {
return fullVersion.substring(0, lastDot);
}
return fullVersion;
}

Copilot uses AI. Check for mistakes.
@Override
Expand Down
Loading