LLVM 22 fixes #909
Merged
LLVM 22 fixes #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/fix_get_next_non_debug
branch
from
ede45e0 to
6797e0f
Compare
coldav
changed the title
llvm PR #144383 removed getNextNonDebugInstruction() and replaced its usage with getNextNode(). Since this replacement seems to have no ill effects, we make the same change here.
This is no longer supported in LLVM 22, so remove reference conditionally.
coldav
force-pushed
the
colin/fix_get_next_non_debug
branch
from
6797e0f to
275e8f3
Compare
…tantiation. LLVM 22 has added a CodeGenOptions parameter to clang::ASTReader so add it conditionally.
coldav
changed the title
hvdijk
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replace getNextNonDebugInstruction() with getNextNode(), LangOptions::Optimize removal and add AstReader CodeGenOptions argument.
Reason for change
LLVM 21 has removed getNextNonDebugInstruction() and replaced its usage with getNextNode(), has removed LangOptions::Optimize and added CodeGenOptions to AstReader.
Description of change
Since this replacement seems to have no ill effects, we make the same change here. as well as adding arguments.