Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate correction for 2D WE #7

Closed
bsmithyman opened this issue Nov 23, 2015 · 6 comments
Closed

Incorporate correction for 2D WE #7

bsmithyman opened this issue Nov 23, 2015 · 6 comments
Assignees

Comments

@bsmithyman
Copy link
Member

Issue by bsmithyman
Tuesday Nov 17, 2015 at 19:20 GMT
Originally opened as uwoseis/anemoi#7


Need to include a wrapper for the 2D wave equation examples that automatically corrects for the 2D vs. 3D Green's function (i.e., half differentiation, half integration).

@bsmithyman
Copy link
Member Author

Comment by bsmithyman
Tuesday Nov 17, 2015 at 19:35 GMT


@ShaunHadden I just added this issue to track the need for handling 2D vs. 3D Green's functions. This is one of the topics that came up in the meeting with Gerhard this morning. It should be semi-general for all of the methods, so we should either implement it in BaseDiscretization, as a wrapper around MiniZephyr and Eurus, or something similar. Just FYI for now.

@bsmithyman
Copy link
Member Author

Comment by ShaunHadden
Tuesday Nov 17, 2015 at 19:40 GMT


ok! This says self-assigned to you, so I am assuming no action is required from me, which makes sense since you said these were just FYI

@bsmithyman
Copy link
Member Author

Comment by bsmithyman
Tuesday Nov 17, 2015 at 19:48 GMT


Yes, exactly :)

@bsmithyman
Copy link
Member Author

Comment by ShaunHadden
Tuesday Nov 17, 2015 at 19:50 GMT


I''ve made the change to the 'Dz' calculation that was wrong on the timedomain branch for eurus.py. This still needs more work so perhaps we should wait to merge it into master?

@bsmithyman
Copy link
Member Author

Comment by bsmithyman
Tuesday Nov 17, 2015 at 19:53 GMT


Thanks for letting me know, but we should use these issues to discuss specific topics, and not mix in other issues. I have created a new spot to discuss the Eurus discretization: #8

@bsmithyman
Copy link
Member Author

Closed by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant