-
Notifications
You must be signed in to change notification settings - Fork 6
Implement address compilation #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces enhancements for address compilation in sed by adding a new module, additional functionality, and documentation updates.
- Added a new module (delimited_parser) in sed.rs
- Added a new "retreat" helper function to ScriptCharProvider
- Provided a default implementation for Command and updated the README with new extension details
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/uu/sed/src/sed.rs | New module added to support delimited parsing functionality. |
src/uu/sed/src/script_char_provider.rs | Added a new retreat function to adjust the character position. |
src/uu/sed/src/command.rs | Introduced a default implementation for Command. |
README.md | Enhanced documentation with extension details. |
Comments suppressed due to low confidence (1)
src/uu/sed/src/script_char_provider.rs:32
- Consider adding unit tests for the new 'retreat' function to verify its behavior on boundary conditions (e.g., when n is greater than or equal to the current position).
pub fn retreat(&mut self, n: usize) {
4cefe3d
to
c650db5
Compare
This can also be used by parse_transliteration
To benefit from having recently worked on the regex code.
c650db5
to
207fee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
I also added unit tests for the new 'retreat' function. |
No description provided.