Skip to content

Implement address compilation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

dspinellis
Copy link
Contributor

No description provided.

@sylvestre sylvestre requested review from Copilot April 27, 2025 12:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces enhancements for address compilation in sed by adding a new module, additional functionality, and documentation updates.

  • Added a new module (delimited_parser) in sed.rs
  • Added a new "retreat" helper function to ScriptCharProvider
  • Provided a default implementation for Command and updated the README with new extension details

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
src/uu/sed/src/sed.rs New module added to support delimited parsing functionality.
src/uu/sed/src/script_char_provider.rs Added a new retreat function to adjust the character position.
src/uu/sed/src/command.rs Introduced a default implementation for Command.
README.md Enhanced documentation with extension details.
Comments suppressed due to low confidence (1)

src/uu/sed/src/script_char_provider.rs:32

  • Consider adding unit tests for the new 'retreat' function to verify its behavior on boundary conditions (e.g., when n is greater than or equal to the current position).
pub fn retreat(&mut self, n: usize) {

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dspinellis
Copy link
Contributor Author

I also added unit tests for the new 'retreat' function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant