Skip to content

Conversation

@Ecordonnier
Copy link
Contributor

@Ecordonnier Ecordonnier commented Dec 9, 2025

No need to use the unsafe libc::execvp(), the standard rust library provides the functionality via Command::exec().

No need to use the unsafe `libc::execvp()`, the standard rust library provides
the functionality via the safe function `Command::exec()`.

Signed-off-by: Etienne Cordonnier <[email protected]>
@Ecordonnier Ecordonnier force-pushed the eco/nice-command-exec branch from b753358 to 260e7ac Compare December 9, 2025 12:44
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/b2sum is no longer failing!

@Ecordonnier Ecordonnier closed this Dec 9, 2025
@Ecordonnier Ecordonnier reopened this Dec 9, 2025
@Ecordonnier
Copy link
Contributor Author

Note that Command::exec() restores the default SIGPIPE signal handler (the rust startup code disables SIGPIPE signal handler). However in this particular case, I think having the default SIGPIPE signal handler is what we want anyway.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant