Stty: Implemented input and output baud rate setting for stty #9517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
stty_input_and_output_speed
branch
2 times, most recently
from
5097f92 to
a1c0044
Compare
|
GNU testsuite comparison: |
This was referenced Nov 29, 2025
ChrisDryden
force-pushed
the
stty_input_and_output_speed
branch
from
a1c0044 to
5a54163
Compare
|
GNU testsuite comparison: |
Contributor
Author
|
Hmm an issue with one of the baud rate integration tests came up, was covered up by the seq failure before |
ChrisDryden
force-pushed
the
stty_input_and_output_speed
branch
from
5a54163 to
2903ff7
Compare
Contributor
Author
|
Darn so it used to be back before 9.2 that it would except invalid arguments without failing? |
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #9517 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
on different platforms the output is different due to different versions so cannot use this as a test.
ChrisDryden
force-pushed
the
stty_input_and_output_speed
branch
from
1f6ede8 to
d018ba7
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two other open stty PR's: #9490 and #9516 . Once those two are merged all of the stty tests pass except for the bad-speed test. This test overrides cfsetispeed and checks to see if it is called. Currently our implementation of stty only overrides the cfsetospeed. The support to do both in GNU existed for a while. I changed the enum and parser to treat the ispeed and ospeed seperately and I added integration tests that compare that using those new flags matches the input and output of the GNU implementation.