-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move signals parameter names to annotation #750
chore: Move signals parameter names to annotation #750
Conversation
211fdad
to
5fb0c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also change
Line 49 in 5fb0c6a
val argumentName = registeredSignal.parameterNames.getOrNull(index) ?: "name_no_provided" |
so possible arg name conflicts are much more likely to occure
...ntry-generator/src/main/kotlin/godot/entrygenerator/generator/SignalRegistrationGenerator.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to update the documentation.
done ! |
59a2d1e
to
629bbf8
Compare
629bbf8
to
5145525
Compare
This moves signal parameter names to annotations.