fix(ci): keep Cargo release versions in sync#666
Merged
jamesbrink merged 3 commits intomainfrom May 7, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 80.67% 78.60% -2.07%
==========================================
Files 79 93 +14
Lines 26985 27924 +939
==========================================
+ Hits 21771 21951 +180
- Misses 5214 5973 +759 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR tightens Rust release automation and CI by making the Rust workspace updater the single source of truth for Cargo version bumps, and by adding a CI guard to prevent workspace version drift (including the new claudette-cli crate).
Changes:
- Remove Cargo manifest entries from Release Please
extra-filesto avoid duplicate/incomplete TOML version handling. - Add a
check-cargo-version-syncscript and a dedicated CI job to fail fast if workspace crate versions diverge orCargo.lockis stale. - Expand Rust CI clippy + coverage runs to include the new
claudette-clicrate, along with a couple clippy-warning cleanups.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/db/test_support.rs |
Removes redundant cfg(test) inner attribute (module is already gated). |
src/agent/naming.rs |
Simplifies error formatting when spawning the Claude process. |
scripts/check-cargo-version-sync.sh |
New script to assert all workspace package versions match and Cargo.lock is usable with --locked. |
release-please-config.json |
Removes Cargo manifests from extra-files so workspace logic owns version bumps. |
.github/workflows/ci.yml |
Adds “Cargo Version Sync” job and includes claudette-cli in clippy + coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the release automation after investigating the May 6, 2026
Release Please - mainfailure and the newsrc-clicrate.Failure investigated: https://github.com/utensils/claudette/actions/runs/25446130425
The failed Release Please run appears to have been a transient GitHub/server-side failure after the release PR branch update succeeded, not a failed published release. While investigating it, the release config showed a brittle Cargo setup: the Rust workspace strategy already discovers and updates all workspace crates, but
release-please-config.jsonalso listed individual Cargo manifests underextra-files. Those extra TOML entries are incomplete for the workspace and are interpreted as top-level$.versionupdates, which produces misleadingNo entries modified in $.versionwarnings.Changes
extra-filesso the Rust workspace updater is the single source of truth for Cargo version bumps.scripts/check-cargo-version-sync.sh, which usescargo metadata --lockedto verify every workspace package has the same version and thatCargo.lockis current.Cargo Version Syncjob to catch future workspace version drift.claudette-clicrate in CI clippy and coverage test commands so it is checked alongsideclaudetteandclaudette-server.RUSTFLAGS=-DwarningsRust CI scope remains viable.Impact
Release Please should continue to update root,
src-tauri,src-server,src-cli, andCargo.lockthrough its Rust workspace logic, but without duplicate generic TOML handling or warning noise. Future Cargo version drift should fail clearly in PR CI instead of being discovered during release automation.Validation
Ran locally:
scripts/check-cargo-version-sync.shbash -n scripts/check-cargo-version-sync.shjq empty release-please-config.json .release-please-manifest.jsongit diff --checkcargo fmt --all --checkRUSTFLAGS='-Dwarnings' cargo clippy -p claudette -p claudette-server -p claudette-cli --all-targets --all-featuresRUSTFLAGS='-Dwarnings' cargo test -p claudette -p claudette-server -p claudette-cli --all-featuresLocal macOS note: the Rust checks required forcing Apple clang in this shell because the default
ccis Nix GCC on macOS and could not link native build scripts correctly. The passing commands usedCARGO_TARGET_AARCH64_APPLE_DARWIN_LINKER=/usr/bin/clang CC=/usr/bin/clang CXX=/usr/bin/clang++ LIBRARY_PATH=.