Skip to content

Replace deprecated com.apple.SoftwareUpdate payload with supported configuration #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nancysangani wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

Replace deprecated com.apple.SoftwareUpdate payload with supported configuration #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rules/system_settings/system_settings_critical_update_install_enforce.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,8 @@ mobileconfig: true
mobileconfig_info:
com.apple.SoftwareUpdate:
CriticalUpdateInstall: true
ddm_info:
declarationtype: com.apple.configuration.softwareupdate.settings
ddm_key: AutomaticActions
ddm_value:
InstallSecurityUpdates: AlwaysOn
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential key mismatch: this rule uses InstallSecurityUpdates under AutomaticActions, but an existing DDM software update rule (system_settings_security_update_install.yaml) uses InstallSecurityUpdate (singular). Since these keys must match Apple’s SoftwareUpdateSettings schema exactly, please verify the correct key name and align usage across rules to avoid generating a non-functional DDM declaration.

Suggested change
InstallSecurityUpdates: AlwaysOn
InstallSecurityUpdate: AlwaysOn

Copilot uses AI. Check for mistakes.
Comment on lines +57 to +61
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new ddm_info block, the rule’s check still inspects the legacy com.apple.SoftwareUpdate defaults (CriticalUpdateInstall). If DDM is the intended enforcement mechanism on supported macOS versions, this check may not reflect the effective policy. Consider validating DDM state from /var/db/softwareupdate/SoftwareUpdateDDMStatePersistence.plist (or otherwise detecting DDM vs profile-backed configuration) so compliance reporting stays accurate.

Copilot uses AI. Check for mistakes.
5 changes: 5 additions & 0 deletions rules/system_settings/system_settings_install_macos_updates_enforce.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,8 @@ mobileconfig: true
mobileconfig_info:
com.apple.SoftwareUpdate:
AutomaticallyInstallMacOSUpdates: true
ddm_info:
declarationtype: com.apple.configuration.softwareupdate.settings
ddm_key: AutomaticActions
ddm_value:
InstallOSUpdates: AlwaysOn
Comment on lines +45 to +49
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a DDM declaration, but the rule’s check still validates com.apple.SoftwareUpdate defaults (AutomaticallyInstallMacOSUpdates). If DDM enforcement doesn’t write these defaults, compliance results can be incorrect on DDM-capable OS versions. Consider adding a DDM-aware check (similar to the /var/db/softwareupdate/SoftwareUpdateDDMStatePersistence.plist approach used in other DDM software update rules) or branching between legacy profile vs DDM state based on OS support.

Copilot uses AI. Check for mistakes.
5 changes: 5 additions & 0 deletions rules/system_settings/system_settings_software_update_download_enforce.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,8 @@ mobileconfig: true
mobileconfig_info:
com.apple.SoftwareUpdate:
AutomaticDownload: true
ddm_info:
declarationtype: com.apple.configuration.softwareupdate.settings
ddm_key: AutomaticActions
ddm_value:
Download: AlwaysOn
Comment on lines +45 to +49
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this rule includes a DDM declaration, the check still reads com.apple.SoftwareUpdate user defaults via osascript. DDM software update settings are typically reflected in /var/db/softwareupdate/SoftwareUpdateDDMStatePersistence.plist (see system_settings_download_software_update_enforce.yaml), so this rule may report non-compliance even when DDM is correctly applied. Consider updating the check to detect/validate the DDM state (or support both mechanisms depending on OS/version).

Copilot uses AI. Check for mistakes.
Loading