Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LED subclass and widgets #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added LED subclass and widgets #16

wants to merge 4 commits into from

Conversation

dnanduri27
Copy link
Contributor

@dnanduri27 dnanduri27 commented Jan 19, 2025

Description (What changed)

Added LED subsystem to robot2025 project to allow control of the CANdle LED driver.

Motivation and Context (Why needed)

Provides visual indication of robot state to the driver via LEDs.

How has this been tested?

  • Compiles with no errors and no additional warnings
  • Simulates without crashes, errors or warnings
  • Simulates with the change under test successfully working
  • Tested in the robot with no crashes, errors or warnings
  • I verified the log messages were as expected with no warnings in AdvantageScope

Screenshots (optional: if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The auto-formatter was working correctly when submitted
  • I have updated any comments accordingly.

Copy link
Contributor

@jmullins16 jmullins16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for being the first to use the template. I added a couple of sentences to complete the Description and Motivation headings in the template.

Everyone should be reviewing this PR and asking questions if they don't understand what it's doing or how it works.

Copy link
Contributor

@Asagarwala2716 Asagarwala2716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@nishka-sethi nishka-sethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants