add api logs #106
Open
add api logs #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KMKoushik I saw this feature PR is still pending. Is there anything that needs to be fixed or implemented on this? |
|
@KMKoushik this is nice aswell :) |
|
sorry, i'm thinking a lot about this pr. this might easily fill up the db and create bunch of issues. i'm not even sure if it;s wise to store logs in postgres atleast directly without any timeseries extension. will not be merging this pr anytime soon. |
|
@KMKoushik What about a seperate clickhouse database to store the logs keeping it seperate from the main database and can be optional. Controlled by the env variables. |
|
I can send an update to the PR with the new approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.