fix: restore comment icon visibility for memos with no comments#5613
Closed
zj1123581321 wants to merge 1 commit intousememos:mainfrom
Closed
fix: restore comment icon visibility for memos with no comments#5613zj1123581321 wants to merge 1 commit intousememos:mainfrom
zj1123581321 wants to merge 1 commit intousememos:mainfrom
Conversation
The comment icon in MemoHeader was completely hidden when commentAmount was 0 due to conditional rendering (introduced in 6264685). This restores the previous behavior where the icon is rendered but hidden via CSS, appearing on hover (desktop) so users can navigate to the detail page to write the first comment. Fixes usememos#5592 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
boojack
force-pushed
the
main
branch
2 times, most recently
from
a196c72 to
71e8a06
Compare
boojack
force-pushed
the
main
branch
2 times, most recently
from
2b6b987 to
47d9414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commentAmount > 0 &&), introduced in commit62646853. This restores the previous CSS-based visibility approach where the icon is hidden by default and shown on hover (desktop), allowing users to navigate to the detail page to write the first comment.Changes
MemoHeader.tsx: ReplacecommentAmount > 0 &&conditional rendering with CSShidden sm:group-hover:flexwhencommentAmount === 0, matching the interaction pattern ofReactionSelectorTest plan
Fixes #5592
🤖 Generated with Claude Code